Skip to content

Add 'less' Text Pagination Functionality to Dynamically View Parts of Large Text #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: theseus_main
Choose a base branch
from
Open

Add 'less' Text Pagination Functionality to Dynamically View Parts of Large Text #1115

wants to merge 56 commits into from

Conversation

@nnh12
Copy link
Contributor

@nnh12 nnh12 commented Dec 5, 2024 •
edited
Loading

This PR restores the less functionality. This displays a small section of text at a time to make viewing large files easier and interactively via the Up and Down key.

Note: Previous implementation relied on app_io to grab a reference to the current terminal and keyboard. However, app_io::get_my_terminal() and app_io::take_key_event_queue() can no longer be supported or re-added due to code structuring. This is why I added the code to the shell application, which already has access to the current terminal and keyboard.

Use the Up and Down key to scroll through text and Q key to quit less mode. Below are some test cases. I added opning_crawl_all.txt for a large file for test.

/extra_files/test_files/text/ : less opening_crawl_all.txt

(Used Down arrow key to scroll through rest of text).

It is a period of civil war.
Rebel spaceships, striking
from a hidden base, have won
their first victory against
the evil Galactic Empire.

During the battle, Rebel
spies managed to steal secret
plans to the Empire's
ultimate weapon, the DEATH
STAR, an armored space
station with enough power to
destroy an entire planet.
...
...

Rebel spaceships, striking
from a hidden base, have won
their first victory against
the evil Galactic Empire.

During the battle, Rebel
spies managed to steal secret
plans to the Empire's
ultimate weapon, the DEATH
STAR, an armored space
station with enough power to
destroy an entire planet.

...
...

from a hidden base, have won
their first victory against
the evil Galactic Empire.

During the battle, Rebel
spies managed to steal secret
plans to the Empire's
ultimate weapon, the DEATH
STAR, an armored space
station with enough power to
destroy an entire planet.

Pursued by the Empire's
...
...

(Using Up key to scroll up).

Rebel spaceships, striking
from a hidden base, have won
their first victory against
the evil Galactic Empire.

During the battle, Rebel
spies managed to steal secret
plans to the Empire's
ultimate weapon, the DEATH
STAR, an armored space
station with enough power to
destroy an entire planet.

...
...

Nathan Hsiao and others added 30 commits November 22, 2024 16:23
@nnh12
Initial attempt to read file into string
aef3885
@nnh12
remove errors to read file into initial string
9f597e2
@nnh12
write content file when 'less' is called
b1bcaa4
@nnh12
add print string contents to verify existing functionality
c22a389
@nnh12
Add terminal size to determine line splice
abe76e2
@nnh12
Save recent progress to use correct terminal size
98a43a3
@nnh12
Add correct instance of Terminal for dimension
727c1fa
@nnh12
Remove window and text display import
583d574
@nnh12
Delete extra 'Terminal' instance
da8fdf8
@nnh12
Initial implementation of display content function
6b871ab
@nnh12
Event handler implementation
c2354b2
@nnh12
Add 'shared_map' to grab the terminal instance
621a857
@nnh12
use new instance of 'Terminal' to write to display
993d6c3
@nnh12
attempt to add libterm dependency
0b2e906
@nnh12
Attempt to display string to terminal
527ca79
@nnh12
Get text pagination to project file onto terminal
2dbf85d
@nnh12
Remove prompt instruction after entering 'less' editing mode
443e782
@nnh12
Add missing text pagination to Missing filename ("less --help" for help)
48724c9
@nnh12
Test 'Tab' command working
f10c4d1
@nnh12
Prelimary key word short cut to Quit
8b7049d
@nnh12
Fix clippy error messages with string format error
1fd2b54
@nnh12
Convert 'str' to String
286ace5
@nnh12
Handle none case with warning
26bf332
@nnh12
Keycode 'Q' to leave out of text
7661174
@nnh12
Remove LineSlice struct for now
bebf802
@nnh12
Remove 'Terminal' instantiation
1230e77
@nnh12
Restart fresh terminal instance upon quiting
b69d78e
@nnh12
Migrate less functionality to 'shell'
b19dc2d
@nnh12
Displayable text added
0c00a64
@nnh12
test file for large file
eeae44d
nnh12 and others added 25 commits November 28, 2024 14:53
@nnh12
Grab the line slices within a text file
d309149
@nnh12
Grab the sliced string against dimension and display
e9c64be
@nnh12
Handle keyboard hits for navigation
05fd274
@nnh12
Quit 'less' upon 'Q' keyboard
6d70adf
@nnh12
remove 's1' clone for testing
351cbf8
@nnh12
Move away from Terminal reference
4c3b55c
@nnh12
access map instance for line access
b137731
@nnh12
Remove previous less command and replace with shell implementation
87a2e1c
@nnh12
Fix 'Q' option to allow user to enter 'q' letter
3149653
@nnh12
Use shell instance of content string to display
3910469
@nnh12
Add 'Up' and 'Down' functionality
71bd2a7
@nnh12
Restore less functionality back to original
345b668
@nnh12
Revert less application to original again
ad24748
@nnh12
again
190c3a4
@nnh12
revert Cargo changes
06a2788
@nnh12
fix line issue
2c34fff
@nnh12
Fix unnnecessary changes
075ab3e
@nnh12
fix again
52d62c8
@nnh12
fix clippy errors
179e743
@nnh12
Revert changes to applications/less/src/lib.rs
cd6f199
@nnh12
Update sytling
29e33e2
@nnh12
Fix clippy errors again
b11c169
@nnh12
fix clippy errors again
b8c6b0c
@nnh12
restore get get content string to return result
ad9724e
@nnh12
Fix issue with map initialization
e7d127f
@nnh12 nnh12 marked this pull request as ready for review December 6, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nnh12